chris/ruwuma
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

common: Disable push rule matching on numbers or booleans

Browse Source 
Spec clarification: https://github.com/matrix-org/matrix-doc/pull/3690
This commit is contained in:
Jonas Platte 2022-02-17 10:09:21 +01:00
parent 7a70d96235
commit f9b9112d07
No known key found for this signature in database
GPG Key ID: CC154DE0E30B7C67
1 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
crates/ruma-common/src/push/condition.rs
View File

@ -291,12 +291,7 @@ impl FlattenedJson {
warn!("Duplicate path in flattened JSON: {}", path); warn!("Duplicate path in flattened JSON: {}", path);
} }
} }
JsonValue::Number(_) | JsonValue::Bool(_) => { JsonValue::Number(_) | JsonValue::Bool(_) | JsonValue::Array(_) | JsonValue::Null => {}
if self.map.insert(path.clone(), value.to_string()).is_some() {
warn!("Duplicate path in flattened JSON: {}", path);
}
}
JsonValue::Array(_) | JsonValue::Null => {}
} }
} }
@ -572,14 +567,7 @@ mod tests {
.unwrap(); .unwrap();
let flattened = FlattenedJson::from_raw(&raw); let flattened = FlattenedJson::from_raw(&raw);
assert_eq!( assert_eq!(flattened.map, btreemap! { "string".into() => "Hello World".into() });
flattened.map,
btreemap! {
"string".into() => "Hello World".into(),
"number".into() => "10".into(),
"boolean".into() => "true".into(),
},
);
} }
#[test] #[test]