chris/ruwuma
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

client-api: Make from optional for get_message_events::Request::new

Browse Source
This commit is contained in:
Johannes Becker 2022-07-15 18:37:28 +02:00 committed by GitHub
parent 8f8937b29e
commit d80e7c9c32
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/ruma-client-api/CHANGELOG.md
View File

@ -5,6 +5,7 @@ Breaking changes:
* Remove `PartialEq` implementations for a number of types * Remove `PartialEq` implementations for a number of types
* If the lack of such an `impl` causes problems, please open a GitHub issue * If the lack of such an `impl` causes problems, please open a GitHub issue
* Split `uiaa::UserIdentifier::ThirdParty` into two separate variants * Split `uiaa::UserIdentifier::ThirdParty` into two separate variants
* Make `message::get_message_events::v3::Request::new`'s `from` parameter optional
Improvements: Improvements:

8
crates/ruma-client-api/src/message/get_message_events.rs
View File

@ -99,10 +99,10 @@ pub mod v3 {
/// Creates a new `Request` with the given parameters. /// Creates a new `Request` with the given parameters.
/// ///
/// All other parameters will be defaulted. /// All other parameters will be defaulted.
pub fn new(room_id: &'a RoomId, from: &'a str, dir: Direction) -> Self { pub fn new(room_id: &'a RoomId, from: Option<&'a str>, dir: Direction) -> Self {
Self { Self {
room_id, room_id,
from: Some(from), from,
to: None, to: None,
dir, dir,
limit: default_limit(), limit: default_limit(),
@ -113,13 +113,13 @@ pub mod v3 {
/// Creates a new `Request` with the given room ID and from token, and `dir` set to /// Creates a new `Request` with the given room ID and from token, and `dir` set to
/// `Backward`. /// `Backward`.
pub fn backward(room_id: &'a RoomId, from: &'a str) -> Self { pub fn backward(room_id: &'a RoomId, from: &'a str) -> Self {
Self::new(room_id, from, Direction::Backward) Self::new(room_id, Some(from), Direction::Backward)
} }
/// Creates a new `Request` with the given room ID and from token, and `dir` set to /// Creates a new `Request` with the given room ID and from token, and `dir` set to
/// `Forward`. /// `Forward`.
pub fn forward(room_id: &'a RoomId, from: &'a str) -> Self { pub fn forward(room_id: &'a RoomId, from: &'a str) -> Self {
Self::new(room_id, from, Direction::Forward) Self::new(room_id, Some(from), Direction::Forward)
} }
/// Creates a new `Request` to fetch messages from the very start of the available history /// Creates a new `Request` to fetch messages from the very start of the available history