chris/ruwuma
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

federation-api: Remove unneeded parameter on get_remote_server_keys_batch

Browse Source 
The `minimum_valid_until_ts` parameter is not needed on this endpoint
(https://matrix.org/docs/spec/server_server/r0.1.4#post-matrix-key-v2-query).
This commit is contained in:
gnieto 2021-11-09 22:09:48 +01:00 committed by GitHub
parent 975efcd2ee
commit b60df453dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/ruma-federation-api/CHANGELOG.md
View File

@ -5,6 +5,7 @@ Breaking changes:
* Replace `Raw<Pdu>` with `Box<RawJsonValue>` or `&RawJsonValue` * Replace `Raw<Pdu>` with `Box<RawJsonValue>` or `&RawJsonValue`
* Borrow more request fields * Borrow more request fields
* Make `device_display_name` field optional in `DeviceListUpdateContent` and update constructor accordingly * Make `device_display_name` field optional in `DeviceListUpdateContent` and update constructor accordingly
* Remove unneeded `minimum_valid_until_ts` query parameter from `get_remote_server_keys_batch` endpoint
# 0.3.1 # 0.3.1

13
crates/ruma-federation-api/src/discovery/get_remote_server_keys_batch/v2.rs
View File

@ -20,14 +20,6 @@ ruma_api! {
} }
request: { request: {
/// The time until which the returned certificates will need to be valid to be useful to
/// the requesting server.
///
/// If not supplied, the current time as determined by the notary server is used.
#[ruma_api(query)]
#[serde(default = "MilliSecondsSinceUnixEpoch::now")]
pub minimum_valid_until_ts: MilliSecondsSinceUnixEpoch,
/// The query criteria. /// The query criteria.
/// ///
/// The outer string key on the object is the server name (eg: matrix.org). The inner /// The outer string key on the object is the server name (eg: matrix.org). The inner
@ -47,12 +39,11 @@ ruma_api! {
} }
impl Request { impl Request {
/// Creates a new `Request` with the given query criteria and `minimum_valid_until` timestamp. /// Creates a new `Request` with the given query criteria.
pub fn new( pub fn new(
server_keys: BTreeMap<ServerNameBox, BTreeMap<ServerSigningKeyId, QueryCriteria>>, server_keys: BTreeMap<ServerNameBox, BTreeMap<ServerSigningKeyId, QueryCriteria>>,
minimum_valid_until_ts: MilliSecondsSinceUnixEpoch,
) -> Self { ) -> Self {
Self { server_keys, minimum_valid_until_ts } Self { server_keys }
} }
} }