From af437bc642e7b42dbc05302e28e6958250505d31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Commaille?= Date: Fri, 16 Jun 2023 08:15:43 +0200 Subject: [PATCH] events: Re-enable clippy::needless_borrow lint It seems false positives have been fixed. --- crates/ruma-common/src/events/room.rs | 3 --- crates/ruma-common/src/events/room/name.rs | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/crates/ruma-common/src/events/room.rs b/crates/ruma-common/src/events/room.rs index 34f9acb6..436b9484 100644 --- a/crates/ruma-common/src/events/room.rs +++ b/crates/ruma-common/src/events/room.rs @@ -2,9 +2,6 @@ //! //! This module also contains types shared by events in its child namespaces. -// https://github.com/rust-lang/rust-clippy/issues/9111 -#![allow(clippy::needless_borrow)] - use std::collections::BTreeMap; use js_int::UInt; diff --git a/crates/ruma-common/src/events/room/name.rs b/crates/ruma-common/src/events/room/name.rs index 3a3dc354..a7a5bb44 100644 --- a/crates/ruma-common/src/events/room/name.rs +++ b/crates/ruma-common/src/events/room/name.rs @@ -39,7 +39,7 @@ mod tests { fn serialization_with_optional_fields_as_none() { let content = RoomNameEventContent { name: Some("The room name".to_owned()) }; - let actual = to_json_value(&content).unwrap(); + let actual = to_json_value(content).unwrap(); let expected = json!({ "name": "The room name", }); @@ -51,7 +51,7 @@ mod tests { fn serialization_with_all_fields() { let content = RoomNameEventContent { name: Some("The room name".to_owned()) }; - let actual = to_json_value(&content).unwrap(); + let actual = to_json_value(content).unwrap(); let expected = json!({ "name": "The room name", });