From 7e210476faad2b19e22766feddfa3c330214f3fe Mon Sep 17 00:00:00 2001
From: Jonas Platte <jplatte+git@posteo.de>
Date: Sat, 19 Oct 2019 02:31:54 +0200
Subject: [PATCH] Re-enable `#![deny(...)]` attributes

---
 src/lib.rs | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index 764238e7..1b6ac335 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -111,8 +111,8 @@
 //! because *m.room.message* implements a *more specific* event trait than `Event`.
 
 #![deny(missing_debug_implementations)]
-//#![deny(missing_docs)]
-//#![deny(warnings)]
+#![deny(missing_docs)]
+#![deny(warnings)]
 
 use std::{
     convert::Infallible,
@@ -247,21 +247,27 @@ impl Display for InvalidInput {
 
 impl Error for InvalidInput {}
 
-/// Marks types that can be deserialized as EventResult<Self> (and don't need fallible conversion
-/// from their raw type)
+/// See `TryFromRaw`. This trait is merely a convenience that can be implemented instead of
+/// `TryFromRaw` to get a `TryFromRaw` implementation with slightly less code if the conversion
+/// can't fail, that is, the raw type and `Self` are identical in definition.
 pub trait FromRaw: Sized {
-    /// The raw form of this event that deserialization falls back to if deserializing `Self` fails.
+    /// The raw type.
     type Raw: DeserializeOwned;
 
+    /// Converts the raw type to `Self`.
     fn from_raw(_: Self::Raw) -> Self;
 }
 
-/// Marks types that can be deserialized as EventResult<Self>
+/// Types corresponding to some item in the matrix spec. Types that implement this trait need to
+/// have a corresponding 'raw' type, a potentially invalid representation that can be converted to
+/// `Self`.
 pub trait TryFromRaw: Sized {
-    /// The raw form of this event that deserialization falls back to if deserializing `Self` fails.
+    /// The raw type.
     type Raw: DeserializeOwned;
+    /// The error type returned if conversion fails.
     type Err: Display;
 
+    /// Tries to convert the raw type to `Self`.
     fn try_from_raw(_: Self::Raw) -> Result<Self, (Self::Err, Self::Raw)>;
 }