chris/ruwuma
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

state-res: Remove unnecessary cloning

Browse Source
This commit is contained in:
Jonas Platte 2021-12-22 17:46:01 +01:00
parent 6abfe3ff70
commit 7cf3abbaf0
No known key found for this signature in database
GPG Key ID: CC154DE0E30B7C67
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crates/ruma-state-res/src/lib.rs
View File

@ -458,18 +458,15 @@ fn iterative_auth_check<E: Event + Clone>(
// The key for this is (eventType + a state_key of the signed token not sender) so // The key for this is (eventType + a state_key of the signed token not sender) so
// search for it // search for it
let current_third_party = auth_events.iter().find_map(|(_, pdu)| { let current_third_party = auth_events.iter().find_map(|(_, pdu)| {
(*pdu.event_type() == EventType::RoomThirdPartyInvite).then(|| { (*pdu.event_type() == EventType::RoomThirdPartyInvite).then(|| pdu)
// TODO no clone, auth_events is borrowed while moved
pdu.clone()
})
}); });
if auth_check( if auth_check(
room_version, room_version,
&event, &event,
most_recent_prev_event.as_ref(), most_recent_prev_event.as_ref(),
current_third_party.as_ref(), current_third_party,
|ty, key| auth_events.get(&(ty.clone(), key.to_owned())).cloned(), |ty, key| auth_events.get(&(ty.clone(), key.to_owned())),
)? { )? {
// add event to resolved state map // add event to resolved state map
resolved_state resolved_state