chris/ruwuma
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove outdated TODOs

Browse Source
This commit is contained in:
Devin Ragotzy 2021-01-14 20:23:46 -05:00
parent d7144e63b7
commit 4cb7353161
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/event_auth.rs
View File

@ -43,7 +43,6 @@ pub fn auth_types_for_event(
} }
} }
// TODO what when we don't find a state_key
let key = (EventType::RoomMember, state_key); let key = (EventType::RoomMember, state_key);
if !auth_types.contains(&key) { if !auth_types.contains(&key) {
auth_types.push(key) auth_types.push(key)

10
src/lib.rs
View File

@ -502,7 +502,6 @@ impl StateResolution {
let mut auth_events = BTreeMap::new(); let mut auth_events = BTreeMap::new();
for aid in &event.auth_events() { for aid in &event.auth_events() {
if let Ok(ev) = StateResolution::get_or_load_event(room_id, &aid, event_map) { if let Ok(ev) = StateResolution::get_or_load_event(room_id, &aid, event_map) {
// TODO what to do when no state_key is found ??
// TODO synapse check "rejected_reason", I'm guessing this is redacted_because in ruma ?? // TODO synapse check "rejected_reason", I'm guessing this is redacted_because in ruma ??
auth_events.insert((ev.kind(), ev.state_key()), ev); auth_events.insert((ev.kind(), ev.state_key()), ev);
} else { } else {
@ -747,14 +746,9 @@ pub fn is_power_event<E: Event>(event: &Arc<E>) -> bool {
event.state_key() == Some("".into()) event.state_key() == Some("".into())
} }
EventType::RoomMember => { EventType::RoomMember => {
if let Ok(content) = if let Ok(content) = serde_json::from_value::<MemberEventContent>(event.content()) {
// TODO fix clone
serde_json::from_value::<MemberEventContent>(event.content())
{
if [MembershipState::Leave, MembershipState::Ban].contains(&content.membership) { if [MembershipState::Leave, MembershipState::Ban].contains(&content.membership) {
return event.sender().as_str() return Some(event.sender().as_str()) != event.state_key().as_deref();
// TODO is None here a failure
!= event.state_key().as_deref().unwrap_or("NOT A STATE KEY");
} }
} }