ci: Improve readability / reduce duplication of workflow files

.github/workflows/audit.yml

@@ -12,7 +12,9 @@ jobs:
     name: Security Audit
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - name: Checkout repo
+        uses: actions/checkout@v2
+
       - uses: actions-rs/audit-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/docs.yml

@@ -16,6 +16,7 @@ jobs:
     steps:
       - name: Checkout repo
         uses: actions/checkout@v2
+
       - name: Install nightly rust toolchain
         uses: actions-rs/toolchain@v1
         with:
@@ -23,7 +24,9 @@ jobs:
           # Needed for use of unstable options
           toolchain: nightly-2022-03-23
           override: true
+
       - uses: Swatinem/rust-cache@v1
+
       - name: Build docs
         uses: actions-rs/cargo@v1
         env:
@@ -31,6 +34,7 @@ jobs:
         with:
           command: doc
           args: --no-deps --workspace --exclude ruma-macros --exclude ruma-identifiers-validation --exclude xtask --all-features -Zrustdoc-map
+
       - name: Deploy to docs branch
         if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
         uses: JamesIves/github-pages-deploy-action@4.1.4

.github/workflows/msrv.yml

@@ -10,77 +10,31 @@ on:
     branches: [main, next]
 
 jobs:
-  all_features:
+  check:
-    name: Check All Features
+    name: ${{ matrix.name }}
     runs-on: ubuntu-latest
-    steps:
+    strategy:
-      - name: Checkout repo
+      matrix:
-        uses: actions/checkout@v2
+        include:
-      - name: Install rust 1.55 toolchain
+          - name: Check All Features
-        uses: actions-rs/toolchain@v1
+            cmd: msrv-all
-        with:
-          profile: minimal
-          toolchain: '1.55'
-      # Used to compile xtask
-      - name: Install rust stable toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-      - uses: Swatinem/rust-cache@v1
-        with:
-          # A stable compiler update should automatically not reuse old caches.
-          # Add the MSRV as a stable cache key too so bumping it also gets us a
-          # fresh cache.
-          sharedKey: msrv1.55
-      - name: Run checks
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci msrv-all
 
-  client:
+          - name: Check Client
-    name: Check Client
+            cmd: msrv-client
-    runs-on: ubuntu-latest
+
-    steps:
+          - name: Check Ruma
-      - name: Checkout repo
+            cmd: msrv-ruma
-        uses: actions/checkout@v2
-      - name: Install rust 1.55 toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: '1.55'
-      # Used to compile xtask
-      - name: Install rust stable toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-      - uses: Swatinem/rust-cache@v1
-        with:
-          # A stable compiler update should automatically not reuse old caches.
-          # Add the MSRV as a stable cache key too so bumping it also gets us a
-          # fresh cache.
-          sharedKey: msrv1.55
-      - name: Run checks
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci msrv-client
 
-  ruma:
-    name: Check Ruma
-    runs-on: ubuntu-latest
     steps:
       - name: Checkout repo
         uses: actions/checkout@v2
+
       - name: Install rust 1.55 toolchain
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
           toolchain: '1.55'
+
       # Used to compile xtask
       - name: Install rust stable toolchain
         uses: actions-rs/toolchain@v1
@@ -88,14 +42,16 @@ jobs:
           profile: minimal
           toolchain: stable
           override: true
+
       - uses: Swatinem/rust-cache@v1
         with:
           # A stable compiler update should automatically not reuse old caches.
           # Add the MSRV as a stable cache key too so bumping it also gets us a
           # fresh cache.
           sharedKey: msrv1.55
+
       - name: Run checks
         uses: actions-rs/cargo@v1
         with:
           command: run
-          args: -p xtask --no-default-features ci msrv-ruma
+          args: -p xtask --no-default-features ci ${{ matrix.cmd }}

.github/workflows/nightly.yml

@@ -10,83 +10,43 @@ on:
     branches: [main, next]
 
 jobs:
-  fmt:
+  check:
-    name: Fmt
+    name: ${{ matrix.name }}
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        include:
+          - name: Check Formatting
+            cmd: fmt
+            components: rustfmt
+
+          - name: Full Features
+            cmd: nightly-full
+
+          - name: Clippy Default Features
+            cmd: clippy-default
+            components: clippy
+
+          - name: Clippy All Features
+            cmd: clippy-all
+            components: clippy
+
     steps:
       - name: Checkout repo
         uses: actions/checkout@v2
+
       - name: Install rust nightly toolchain
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
           toolchain: nightly-2022-03-23
           override: true
-          components: rustfmt
+          components: ${{ matrix.components }}
+
       - uses: Swatinem/rust-cache@v1
+
       - name: Run checks
         uses: actions-rs/cargo@v1
         with:
           command: run
-          args: -p xtask --no-default-features ci fmt
+          args: -p xtask --no-default-features ci ${{ matrix.cmd }}
-
-  check_full:
-    name: Check Full Features
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-      - name: Install rust nightly toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: nightly-2022-03-23
-          override: true
-      - uses: Swatinem/rust-cache@v1
-      - name: Run checks
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci nightly-full
-
-  clippy_default:
-    name: Clippy Default Features
-    runs-on: ubuntu-latest
-    needs: check_full
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-      - name: Install rust nightly toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: nightly-2022-03-23
-          override: true
-          components: clippy
-      - uses: Swatinem/rust-cache@v1
-      - name: Run lints
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci clippy-default
-
-  clippy_all:
-    name: Clippy All Features
-    runs-on: ubuntu-latest
-    needs: check_full
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-      - name: Install rust nightly toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: nightly-2022-03-23
-          override: true
-          components: clippy
-      - uses: Swatinem/rust-cache@v1
-      - name: Run lints
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci clippy-all

.github/workflows/stable.yml

@@ -10,119 +10,45 @@ on:
     branches: [main, next]
 
 jobs:
-  check_all:
+  check:
-    name: Check All Features
+    name: ${{ matrix.name }}
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        include:
+          - name: Check All Features
+            cmd: stable-all
+
+          - name: Check Client
+            cmd: stable-client
+
+          - name: Check Common
+            cmd: stable-common
+
+          - name: Run Tests
+            cmd: test-all
+
+          - name: Run Doc Tests
+            cmd: test-doc
+
+          - name: Test Common Features
+            cmd: test-common
+
     steps:
       - name: Checkout repo
         uses: actions/checkout@v2
+
       - name: Install rust stable toolchain
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
           toolchain: stable
           override: true
+
       - uses: Swatinem/rust-cache@v1
+
       - name: Run checks
         uses: actions-rs/cargo@v1
         with:
           command: run
-          args: -p xtask --no-default-features ci stable-all
+          args: -p xtask --no-default-features ci ${{ matrix.cmd }}
-
-  check_client:
-    name: Check Client
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-      - name: Install rust stable toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-      - uses: Swatinem/rust-cache@v1
-      - name: Run checks
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci stable-client
-
-  check_common:
-    name: Check Common
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-      - name: Install rust stable toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-      - uses: Swatinem/rust-cache@v1
-      - name: Run checks
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci stable-common
-
-  test_all:
-    name: Run Tests
-    runs-on: ubuntu-latest
-    needs: check_all
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-      - name: Install rust stable toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-      - uses: Swatinem/rust-cache@v1
-      - name: Run tests
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci test-all
-
-  test_doc:
-    name: Run Doc Tests
-    runs-on: ubuntu-latest
-    needs: check_all
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-      - name: Install rust stable toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-      - uses: Swatinem/rust-cache@v1
-      - name: Run tests
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci test-doc
-
-  test_common:
-    name: Test Common Features
-    runs-on: ubuntu-latest
-    needs: check_common
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v2
-      - name: Install rust stable toolchain
-        uses: actions-rs/toolchain@v1
-        with:
-          profile: minimal
-          toolchain: stable
-          override: true
-      - uses: Swatinem/rust-cache@v1
-      - name: Run tests
-        uses: actions-rs/cargo@v1
-        with:
-          command: run
-          args: -p xtask --no-default-features ci test-common

.github/workflows/style.yml

@@ -23,13 +23,17 @@ jobs:
           profile: minimal
           toolchain: nightly-2022-03-23
           override: true
+
       - uses: Swatinem/rust-cache@v1
+
       - name: Check spelling
         uses: crate-ci/typos@master
+
       - name: Install cargo-sort
         uses: actions-rs/install@v0.1
         with:
           crate: cargo-sort
+
       - name: Run lints
         uses: actions-rs/cargo@v1
         with: